Parse and fix broken github api urls#82
Merged
chondent merged 2 commits intospotify:masterspotify/github-java-client:masterfrom Nov 18, 2021
chondent:fix-invalid-github-urlchondent/github-java-client:fix-invalid-github-urlCopy head branch name to clipboard
Merged
Parse and fix broken github api urls#82chondent merged 2 commits intospotify:masterspotify/github-java-client:masterfrom chondent:fix-invalid-github-urlchondent/github-java-client:fix-invalid-github-urlCopy head branch name to clipboard
chondent merged 2 commits intospotify:masterspotify/github-java-client:masterfrom
chondent:fix-invalid-github-urlchondent/github-java-client:fix-invalid-github-urlCopy head branch name to clipboard
Conversation
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
============================================
+ Coverage 68.83% 70.20% +1.37%
- Complexity 198 222 +24
============================================
Files 32 36 +4
Lines 770 866 +96
Branches 33 36 +3
============================================
+ Hits 530 608 +78
- Misses 217 233 +16
- Partials 23 25 +2
Continue to review full report at Codecov.
|
dennisgranath
previously approved these changes
Nov 8, 2021
Contributor
Author
|
Just realised this won't handle branches with forward slashes in the name. Working on a fix. |
a2d7570 to
a4573e4
Compare
If a branch has a percent symbol in it, github will sometimes return a URI that java's URI object can't parse. This patch ensures that in such a case we url-escape the branch name.
a4573e4 to
22bce81
Compare
vchernodon
reviewed
Nov 12, 2021
| Optional<URI> protectionUrl(); | ||
| } | ||
|
|
||
| class BranchDeserializer extends JsonDeserializer<ImmutableBranch> { |
Contributor
There was a problem hiding this comment.
Could BranchDeserializer class be defined in a separate file (BranchDeserializer.java)?
I understand it compiles just fine and it is a matter of taste... The current code within BranchDeserializer does not look like a data structure definition for example, but rather a utility class.
The code might be cleaner if class is defined within its own java file and it would allow for reusability (if needed).
This is just a comment.
dziemba
added a commit
that referenced
this pull request
Apr 13, 2022
In #82 we added a custom deserializer for the `Branch` class. This deserializer didn't handle certain cases properly that the GH API would return. In particular the case where the `protected` field was set and no `protection_url` is present would lead to a NPE in the deserializer. To avoid this error and make the whole parser more resilient to different API results, let's reduce the scope of the custom deserializer to only parse the `protection_url` field instead of the whole `Branch` class. There should be no change in runtime behavior apart from fixing the error cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a branch has a percent symbol in it, github will sometimes return a
URI that java's URI object can't parse. This patch ensures that in such
a case we url-escape the branch name.