added check for missing HTTP_ACCEPT_LANGUAGE and minor change in de translation#334
Open
HonkXL wants to merge 3 commits into
Open
added check for missing HTTP_ACCEPT_LANGUAGE and minor change in de translation#334HonkXL wants to merge 3 commits into
HonkXL wants to merge 3 commits into
Conversation
added a check if HTTP_ACCEPT_LANGUAGE header exists. Some bots and browsers don't send this and this results in error messages in the log
Changed "Fehlt" to "fehlt" to be consistent.
Changed "Fehlt" to "fehlt" to be consistent
splitbrain
reviewed
Jan 23, 2026
| global $conf; | ||
| $langs = $this->translations; | ||
| // Check if HTTP_ACCEPT_LANGUAGE header exists | ||
| if (!isset($_SERVER['HTTP_ACCEPT_LANGUAGE']) || empty($_SERVER['HTTP_ACCEPT_LANGUAGE'])) { |
Owner
There was a problem hiding this comment.
empty() includes the isset check. no need for both.
splitbrain
reviewed
Jan 23, 2026
| { | ||
| global $conf; | ||
| $langs = $this->translations; | ||
| // Check if HTTP_ACCEPT_LANGUAGE header exists |
Owner
There was a problem hiding this comment.
this comment is a bit silly, it basically repeats what the code says
Owner
|
@copilot please review my comments and create a pr fixing them |
Owner
|
well, it was worth a try but seems not work. will the issues myself when I get to a computer.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added check for missing HTTP_ACCEPT_LANGUAGE. Some Browsers and Bots are not sendig this header. This results in many errors in the DokuWiki-Log.
minor change in de translation: "Fehlt" changed to "fehlt" to be consistent with the other words that are lowercased.