Auto-generate spinnaker-local.yml on run_dev first's run. - #593
#593Merged
duftler merged 1 commit intoNov 19, 2015
spinnaker:masterspinnaker/spinnaker:masterfrom
ewiseblatt:2_run_dev_autoconfigureewiseblatt/spinnaker:2_run_dev_autoconfigureCopy head branch name to clipboard
Merged
Auto-generate spinnaker-local.yml on run_dev first's run.#593duftler merged 1 commit intospinnaker:masterspinnaker/spinnaker:masterfrom ewiseblatt:2_run_dev_autoconfigureewiseblatt/spinnaker:2_run_dev_autoconfigureCopy head branch name to clipboard
duftler merged 1 commit into
spinnaker:masterspinnaker/spinnaker:masterfrom
ewiseblatt:2_run_dev_autoconfigureewiseblatt/spinnaker:2_run_dev_autoconfigureCopy head branch name to clipboard
Conversation
There was a problem hiding this comment.
I think us-central1-f is a better choice for a baked-in default.
|
LGTM. |
This avoids the need to remove the environment variables from the spinnaker-local.yml
ewiseblatt
force-pushed
the
2_run_dev_autoconfigure
branch
from
November 19, 2015 03:57
4732bc8 to
d73f9ce
Compare
Author
|
ok. I updated the README as well |
duftler
pushed a commit
that referenced
this pull request
Nov 19, 2015
Auto-generate spinnaker-local.yml on run_dev first's run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@duftler