Added transformation from old yaml to new yaml for click to deploy. - #528
#528Added transformation from old yaml to new yaml for click to deploy.#528ewiseblatt merged 1 commit into
Conversation
|
LGTM. |
|
Feel free to self-merge when ready. |
Added transformation from old yaml to new yaml for click to deploy.
There was a problem hiding this comment.
@ewiseblatt This change would end up causing things to fail to start since it means the referenced property is required. I'm replacing this with ${SPINNAKER_GOOGLE_PROJECT_CREDENTIALS_PATH:} in the next PR.
There was a problem hiding this comment.
Good idea. There is a default empty value in /etc/default/spinnaker (that I
added -- or at least meant to)
On Sun, Nov 15, 2015 at 9:13 PM, Matt Duftler notifications@github.com
wrote:
In config/default-spinnaker-local.yml
#528 (comment):primaryCredentials: name: my-google-account # The project is the Google Project ID for the project to manage with Spinnaker. # The jsonPath is a path to the JSON service credentials downloaded from the # Google Developer's Console. project: ${SPINNAKER_GOOGLE_PROJECT_ID}
jsonPath:jsonPath: ${SPINNAKER_GOOGLE_PROJECT_CREDENTIALS_PATH}@ewiseblatt https://github.com/ewiseblatt This change would end up
causing things to fail to start since it means the referenced property is
required. I'm replacing this with
${SPINNAKER_GOOGLE_PROJECT_CREDENTIALS_PATH:} in the next PR.—
Reply to this email directly or view it on GitHub
https://github.com/spinnaker/spinnaker/pull/528/files#r44883717.
This works with the old yaml. It might not work with the new yaml.
Will fix that in followup CL.
@duftler, @skim1420