Disable bundler cache in push_gem.yml#76
Disable bundler cache in push_gem.yml#76connorshea wants to merge 2 commits into
Conversation
For the sake of safety, to avoid potential cache poisoning attacks. It's unlikely, but the cache also saves very little time here, so I think it's worth doing.
Otherwise the patch breaks the workflow, I didn't realize the bundler-cache value was the only reason `bundle install` ran 🙃
|
Added an explicit |
|
@connorshea Thanks for opening this PR. It prompted me to do a full GitHub Actions hardening pass on the repo, see #83. I was wondering about cache-poisoning, and I'm not sure that it's an attack vector for this workflow. GitHub Actions caches are isolated by git ref. A cache created by a pull request lives in the This So instead of turning caching off (which also needs the extra I'm asking because I'd like to really understand this attack vector a bit better -- I have an agent skill to perform workflow hardening and I want to make sure it's doing the right thing. |
For the sake of safety, to avoid potential cache poisoning attacks. It's unlikely, but the cache also saves very little time here, so I think it's worth doing.