This repository was archived by the owner on Nov 6, 2018. It is now read-only.
fix: error emitted from a hover provider broke other hover providers#117
Merged
attfarhan merged 3 commits intoOct 31, 2018
mastersourcegraph/sourcegraph-extension-api:masterfrom
fa/fix-hover-clashingsourcegraph/sourcegraph-extension-api:fa/fix-hover-clashingCopy head branch name to clipboard
Merged
fix: error emitted from a hover provider broke other hover providers#117attfarhan merged 3 commits intomastersourcegraph/sourcegraph-extension-api:masterfrom fa/fix-hover-clashingsourcegraph/sourcegraph-extension-api:fa/fix-hover-clashingCopy head branch name to clipboard
attfarhan merged 3 commits into
mastersourcegraph/sourcegraph-extension-api:masterfrom
fa/fix-hover-clashingsourcegraph/sourcegraph-extension-api:fa/fix-hover-clashingCopy head branch name to clipboard
Conversation
sqs
approved these changes
Oct 30, 2018
sqs
left a comment
Member
There was a problem hiding this comment.
We’ll see if we need to rate limit the error logging of a lot of duplicates get logged. This is good for now.
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
+ Coverage 77.58% 77.62% +0.03%
==========================================
Files 67 67
Lines 2628 2632 +4
Branches 534 534
==========================================
+ Hits 2039 2043 +4
Misses 589 589
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 18.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105
Errors from hover providers will be logged in the console, but not emitted from
getHover. Now, other hover providers will continue to work if one hover provider is emitting errors. However, this means that errors won't appear in the hover tooltip when they do occur.