Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Nov 6, 2018. It is now read-only.

Commit ac790f2

Browse filesBrowse files
committed
feat: remove sourcegraphURL from extension API
It was not used and is not necessary.
1 parent 6058e64 commit ac790f2
Copy full SHA for ac790f2

3 files changed

+1-16Lines changed: 1 addition & 16 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/extension/extensionHost.ts‎

Copy file name to clipboardExpand all lines: src/extension/extensionHost.ts
-4Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,6 @@ const consoleLogger: Logger = {
3636
export interface InitData {
3737
/** The URL to the JavaScript source file (that exports an `activate` function) for the extension. */
3838
bundleURL: string
39-
40-
/** @see {@link module:sourcegraph.internal.sourcegraphURL} */
41-
sourcegraphURL: string
4239
}
4340

4441
/**
@@ -140,7 +137,6 @@ function createExtensionHandle(initData: InitData, connection: Connection): type
140137
internal: {
141138
sync,
142139
updateContext: updates => context.updateContext(updates),
143-
sourcegraphURL: new URI(initData.sourcegraphURL),
144140
},
145141
}
146142
}
Collapse file

‎src/integration-test/helpers.test.ts‎

Copy file name to clipboardExpand all lines: src/integration-test/helpers.test.ts
+1-4Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,7 @@ export async function integrationTestContext(): Promise<
4040
// Ack all configuration updates.
4141
clientController.configurationUpdates.subscribe(({ resolve }) => resolve(Promise.resolve()))
4242

43-
const extensionHost = createExtensionHost(
44-
{ bundleURL: '', sourcegraphURL: 'https://example.com' },
45-
serverTransports
46-
)
43+
const extensionHost = createExtensionHost({ bundleURL: '' }, serverTransports)
4744

4845
// Wait for client to be ready.
4946
await clientController.clientEntries
Collapse file

‎src/sourcegraph.d.ts‎

Copy file name to clipboardExpand all lines: src/sourcegraph.d.ts
-8Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -829,14 +829,6 @@ declare module 'sourcegraph' {
829829
* @param updates The updates to apply to the context. If a context property's value is null, it is deleted from the context.
830830
*/
831831
export function updateContext(updates: ContextValues): void
832-
833-
/**
834-
* The URL to the Sourcegraph site that the user's session is associated with. This refers to
835-
* Sourcegraph.com (`https://sourcegraph.com`) by default, or a self-hosted instance of Sourcegraph.
836-
*
837-
* @example `https://sourcegraph.com`
838-
*/
839-
export const sourcegraphURL: URI
840832
}
841833

842834
/**

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.