Use errors.Is/errors.As instead of == comparisons against errors#83
Closed
bahrmichael wants to merge 1 commit into
mastersourcegraph/go-diff:masterfrom
errors-is-as-migration-7f3a1csourcegraph/go-diff:errors-is-as-migration-7f3a1cCopy head branch name to clipboard
Closed
Use errors.Is/errors.As instead of == comparisons against errors#83bahrmichael wants to merge 1 commit intomastersourcegraph/go-diff:masterfrom errors-is-as-migration-7f3a1csourcegraph/go-diff:errors-is-as-migration-7f3a1cCopy head branch name to clipboard
bahrmichael wants to merge 1 commit into
mastersourcegraph/go-diff:masterfrom
errors-is-as-migration-7f3a1csourcegraph/go-diff:errors-is-as-migration-7f3a1cCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change replaces direct
==/!=comparisons against error values with thestandard library helpers
errors.Is(for sentinel error values) anderrors.As(for error types).
Direct comparison breaks when an error is wrapped (e.g. with
fmt.Errorf("...: %w", err)),whereas
errors.Is/errors.Astraverse the wrap chain.Notes:
nilare intentionally left unchanged.Created by Sourcegraph batch change
bahrmichael/432ac474-d2a7-4950-b17f-2a1b1fe59e87.