Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add support for special characters in file names#45

Merged
eseliger merged 1 commit into
mastersourcegraph/go-diff:masterfrom
es/quoted-filenamessourcegraph/go-diff:es/quoted-filenamesCopy head branch name to clipboard
May 8, 2020
Merged

Add support for special characters in file names#45
eseliger merged 1 commit into
mastersourcegraph/go-diff:masterfrom
es/quoted-filenamessourcegraph/go-diff:es/quoted-filenamesCopy head branch name to clipboard

Conversation

@eseliger

@eseliger eseliger commented May 8, 2020

Copy link
Copy Markdown
Member

Closes #43

@codecov

codecov Bot commented May 8, 2020

Copy link
Copy Markdown

Codecov Report

Merging #45 into master will increase coverage by 1.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   26.91%   28.12%   +1.20%     
==========================================
  Files           5        5              
  Lines        1133     1152      +19     
==========================================
+ Hits          305      324      +19     
  Misses        784      784              
  Partials       44       44              
Impacted Files Coverage Δ
diff/parse.go 80.85% <100.00%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adde711...51b4e38. Read the comment docs.

@keegancsmith keegancsmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is stuff from git encoded in the same way that go's Unquote... unquotes? Either way LGTM :)

@eseliger eseliger merged commit 8c3ae63 into master May 8, 2020
@eseliger eseliger deleted the es/quoted-filenames branch May 8, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No proper handling for special characters in file names

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.