Exclude copyWith method from number_of_parameters rule#196
Merged
yurii-prykhodko-solid merged 5 commits intoJan 31, 2025
solid-software:mastersolid-software/solid_lints:masterfrom
Aygistov:Issue-124-exclude-copy_with-method-from-number_of_parameters-ruleAygistov/solid_lints:Issue-124-exclude-copy_with-method-from-number_of_parameters-ruleCopy head branch name to clipboard
Merged
Exclude copyWith method from number_of_parameters rule#196yurii-prykhodko-solid merged 5 commits intosolid-software:mastersolid-software/solid_lints:masterfrom Aygistov:Issue-124-exclude-copy_with-method-from-number_of_parameters-ruleAygistov/solid_lints:Issue-124-exclude-copy_with-method-from-number_of_parameters-ruleCopy head branch name to clipboard
yurii-prykhodko-solid merged 5 commits into
solid-software:mastersolid-software/solid_lints:masterfrom
Aygistov:Issue-124-exclude-copy_with-method-from-number_of_parameters-ruleAygistov/solid_lints:Issue-124-exclude-copy_with-method-from-number_of_parameters-ruleCopy head branch name to clipboard
Conversation
yurii-prykhodko-solid
requested changes
Jan 30, 2025
yurii-prykhodko-solid
left a comment
Collaborator
There was a problem hiding this comment.
Please add tests.
yurii-prykhodko-solid
requested changes
Jan 30, 2025
yurii-prykhodko-solid
left a comment
Collaborator
There was a problem hiding this comment.
Also update the changelog, please.
Comment on lines
+18
to
+19
| - method_name: avoidNumberOfParameters | ||
| - method_name: avoidNumberOfParameters | ||
| - method_name: copyWith |
Collaborator
There was a problem hiding this comment.
We should check that the standard rule set works -- not a custom subset that we define here.
Let's create a separate nested package inside of lint_test, with its own pubspec and a clean analysis_options which would just import the standard rule set -- and then test on that.
Contributor
Author
There was a problem hiding this comment.
Made changes, please check.
yurii-prykhodko-solid
approved these changes
Jan 31, 2025
yurii-prykhodko-solid
left a comment
Collaborator
There was a problem hiding this comment.
Looking good! Just a couple nits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #124