Issue 167 1#186
Merged
yurii-prykhodko-solid merged 15 commits intoDec 6, 2024
Merged
Issue 167 1#186yurii-prykhodko-solid merged 15 commits into
yurii-prykhodko-solid merged 15 commits into
Conversation
added 8 commits
December 4, 2024 15:28
yurii-prykhodko-solid
requested changes
Dec 4, 2024
yurii-prykhodko-solid
left a comment
Collaborator
There was a problem hiding this comment.
Let's add at least one test per each rule, where we check whether the exclusion logic is working properly.
And please make sure the pipeline is passing.
yurii-prykhodko-solid
requested changes
Dec 5, 2024
yurii-prykhodko-solid
requested changes
Dec 5, 2024
| final excludedItem = | ||
| exclude.firstWhereOrNull((e) => e.methodName == methodName); | ||
| final excludedItem = exclude.firstWhereOrNull( | ||
| (e) => e.methodName == methodName || e.className == methodName, |
Collaborator
There was a problem hiding this comment.
This removes some confusion.
And also highlights that we may not be comparing what we think we should be comparing.
We should check whether the declaration is a class before running exclude.className == declarationName; same for method names.
Suggested change
| (e) => e.methodName == methodName || e.className == methodName, | |
| (e) => e.methodName == declarationName || e.className == declarationName, |
yurii-prykhodko-solid
requested changes
Dec 5, 2024
yurii-prykhodko-solid
left a comment
Collaborator
There was a problem hiding this comment.
Looking good, almost there. Please add tests for plain-string exclude.
yurii-prykhodko-solid
requested changes
Dec 6, 2024
Comment on lines
+10
to
+11
| - method_name: longFunctionExcluded | ||
| - method_name: longMethodExcluded |
Collaborator
There was a problem hiding this comment.
Let's change this back. If no tests fail -- we're good to go.
Suggested change
| - method_name: longFunctionExcluded | |
| - method_name: longMethodExcluded | |
| - longFunctionExcluded | |
| - longMethodExcluded |
yurii-prykhodko-solid
requested changes
Dec 6, 2024
Comment on lines
+53
to
+61
| for (final item in excludeList) { | ||
| if (item is Map) { | ||
| exclude.add(ExcludedIdentifierParameter.fromJson(item)); | ||
| } else if (item is String) { | ||
| exclude.add( | ||
| ExcludedIdentifierParameter( | ||
| declarationName: item, | ||
| ), | ||
| ); |
Collaborator
There was a problem hiding this comment.
You can replace all this with a call to another factory, to avoid duplication
return ExcludedIdentifiersListParameter.fromJson(excludeList: excludeList);
yurii-prykhodko-solid
approved these changes
Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.