Improved avoid_late_keyword to support ignoring the subtype of the node type (#157)#158
Merged
illia-romanenko merged 7 commits intoApr 18, 2024
Merged
Improved avoid_late_keyword to support ignoring the subtype of the node type (#157)#158
avoid_late_keyword to support ignoring the subtype of the node type (#157)#158Conversation
…node type (support for nested types for dynamic, Object?, Object) solid-software#157
yurii-prykhodko-solid
requested changes
Apr 15, 2024
yurii-prykhodko-solid
left a comment
Collaborator
There was a problem hiding this comment.
General logic LGTM, great start!;
Implementation-wise -- I think we are relying on raw regexp/string matching too much here. We should try and leverage the static types and utilities that analyzer/ast provides us.
Here's some stuff we may be able to use:
- https://pub.dev/documentation/analyzer/latest/dart_ast_token/Keyword/DYNAMIC-constant.html
- https://pub.dev/documentation/analyzer/latest/dart_element_type/DynamicType-class.html
- https://pub.dev/documentation/analyzer/latest/dart_element_type_provider/TypeProvider/objectType.html
- https://pub.dev/documentation/analyzer/latest/dart_element_type/TypeParameterType-class.html
We should also be more vigorous about testing this. I've added a couple ideas, but I'm sure you can expand on them.
Co-authored-by: Yurii Prykhodko <144313329+yurii-prykhodko-solid@users.noreply.github.com>
Co-authored-by: Yurii Prykhodko <144313329+yurii-prykhodko-solid@users.noreply.github.com>
Yarl745
commented
Apr 16, 2024
…lyze and compare type names
yurii-prykhodko-solid
requested changes
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
avoid_late_keyword-ignored_typesnot working as expected. #157