Add a rule prefer_guard_clause for reversing nested if statements#154
Merged
illia-romanenko merged 12 commits intoApr 22, 2024
solid-software:mastersolid-software/solid_lints:masterfrom
velvitoff:use_reverse_if_to_reduce_nestingCopy head branch name to clipboard
Merged
Add a rule prefer_guard_clause for reversing nested if statements#154illia-romanenko merged 12 commits intosolid-software:mastersolid-software/solid_lints:masterfrom velvitoff:use_reverse_if_to_reduce_nestingCopy head branch name to clipboard
prefer_guard_clause for reversing nested if statements#154illia-romanenko merged 12 commits into
solid-software:mastersolid-software/solid_lints:masterfrom
velvitoff:use_reverse_if_to_reduce_nestingCopy head branch name to clipboard
Conversation
yurii-prykhodko-solid
requested changes
Mar 28, 2024
yurii-prykhodko-solid
left a comment
Collaborator
There was a problem hiding this comment.
The idea seems to mostly work, but I think we lack a clear definition of what we're trying to do here.
I'd look to these cases:
- when
ifblock is spanning the entire function body:
void fn() {
if (true) {
...
}
}
// ->>
void fn() {
if (false) return;
...
}- when
if-elseis spanning the entire function body
yurii-prykhodko-solid
requested changes
Mar 29, 2024
yurii-prykhodko-solid
left a comment
Collaborator
There was a problem hiding this comment.
This looks like a great start for this lint!
We can expand on it in next iterations.
For now, just need to fixup a few minor issues, and clarify a few pieces.
vladimir-beloded
suggested changes
Mar 29, 2024
illia-romanenko
approved these changes
Apr 22, 2024
illia-romanenko
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - but missing changelog, I'll add it myself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.