- Added excludeNames param for function_lines_of_code lint#141
Merged
aderhachev merged 6 commits intoMar 15, 2024
mastersolid-software/solid_lints:masterfrom
Andrii-Derhachev-function_lines_of_code_improvementsolid-software/solid_lints:Andrii-Derhachev-function_lines_of_code_improvementCopy head branch name to clipboard
Merged
- Added excludeNames param for function_lines_of_code lint#141aderhachev merged 6 commits intomastersolid-software/solid_lints:masterfrom Andrii-Derhachev-function_lines_of_code_improvementsolid-software/solid_lints:Andrii-Derhachev-function_lines_of_code_improvementCopy head branch name to clipboard
excludeNames param for function_lines_of_code lint#141aderhachev merged 6 commits into
mastersolid-software/solid_lints:masterfrom
Andrii-Derhachev-function_lines_of_code_improvementsolid-software/solid_lints:Andrii-Derhachev-function_lines_of_code_improvementCopy head branch name to clipboard
Conversation
- Refactored tests for function_lines_of_code
solid-vovabeloded
requested changes
Mar 13, 2024
solid-vovabeloded
left a comment
Collaborator
There was a problem hiding this comment.
Added a few suggestions here, but looks good overall.
Comment on lines
+63
to
+73
| final name = () { | ||
| if (node is FunctionDeclaration) { | ||
| return node.name.lexeme; | ||
| } else if (node is MethodDeclaration) { | ||
| return node.name.lexeme; | ||
| } else if (node is FunctionExpression) { | ||
| return node.declaredElement?.name; | ||
| } else { | ||
| return null; | ||
| } | ||
| }(); |
Collaborator
There was a problem hiding this comment.
Please, extract this into a separate private method or just inline it into current method. Do not use inline function declaration since it hurts readability.
| /// exceeding this limit triggers a warning. | ||
| final int maxLines; | ||
|
|
||
| /// Method names to be excluded from the rule check |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// Method names to be excluded from the rule check | |
| /// Function names to be excluded from the rule check |
Does it make sense to be consistent with all the rest documentation/naming?
Comment on lines
+19
to
+21
| return i; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Would be great to also test that it does not report false positives for both - methods and functions.
Collaborator
There was a problem hiding this comment.
Thanks for changing the file name to a proper one!
solid-vovabeloded
approved these changes
Mar 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
excludeNamesparam forfunction_lines_of_codelint