Avoid debug print#134
Merged
yurii-prykhodko-solid merged 5 commits intoMar 12, 2024
solid-software:mastersolid-software/solid_lints:masterfrom
Viktor-Mudrytskyi:avoid_debug_printViktor-Mudrytskyi/solid_lints:avoid_debug_printCopy head branch name to clipboard
Merged
Avoid debug print#134yurii-prykhodko-solid merged 5 commits intosolid-software:mastersolid-software/solid_lints:masterfrom Viktor-Mudrytskyi:avoid_debug_printViktor-Mudrytskyi/solid_lints:avoid_debug_printCopy head branch name to clipboard
yurii-prykhodko-solid merged 5 commits into
solid-software:mastersolid-software/solid_lints:masterfrom
Viktor-Mudrytskyi:avoid_debug_printViktor-Mudrytskyi/solid_lints:avoid_debug_printCopy head branch name to clipboard
Conversation
e36467c to
f3dbc14
Compare
yurii-prykhodko-solid
requested changes
Mar 12, 2024
| void _handleVariableAssignmentDeclaration({ | ||
| required AstNode node, | ||
| required ErrorReporter reporter, | ||
| required Iterable<SyntacticEntity> childEntities, |
Collaborator
There was a problem hiding this comment.
unused arg; you're retrieving the childEntites from node.
Suggested change
| required Iterable<SyntacticEntity> childEntities, |
Comment on lines
+114
to
+120
| if (rightOperand == null) { | ||
| return; | ||
| } | ||
|
|
||
| if (rightOperand is! Identifier) { | ||
| return; | ||
| } |
Collaborator
There was a problem hiding this comment.
Simplify:
Suggested change
| if (rightOperand == null) { | |
| return; | |
| } | |
| if (rightOperand is! Identifier) { | |
| return; | |
| } | |
| if (rightOperand == null || rightOperand is! Identifier) { | |
| return; | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.