Docs: remove superfluous files - #2181
#2181Merged
lukegalbraithrussell merged 4 commits intoAug 1, 2024
mainslackapi/bolt-js:mainfrom
luke-streamline-site-contentslackapi/bolt-js:luke-streamline-site-contentCopy head branch name to clipboard
Merged
Docs: remove superfluous files#2181lukegalbraithrussell merged 4 commits intomainslackapi/bolt-js:mainfrom luke-streamline-site-contentslackapi/bolt-js:luke-streamline-site-contentCopy head branch name to clipboard
lukegalbraithrussell merged 4 commits into
mainslackapi/bolt-js:mainfrom
luke-streamline-site-contentslackapi/bolt-js:luke-streamline-site-contentCopy head branch name to clipboard
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2181 +/- ##
=======================================
Coverage 82.07% 82.07%
=======================================
Files 18 18
Lines 1545 1545
Branches 443 443
=======================================
Hits 1268 1268
Misses 179 179
Partials 98 98 ☔ View full report in Codecov by Sentry. |
haleychaas
approved these changes
Aug 1, 2024
This was referenced Sep 5, 2024
This was referenced Sep 13, 2024
This was referenced Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I misunderstood how the Japanese version of the site works.
Incorrect: The Japanese site needs English file copies to fill in if there are not certain Japanese translated files
Correct: The Japanese site uses the original English files to fill in if there are not certain Japanese translated files
Therefore, the copies of English files in the Japanese section of the docs can be removed. This is great news. woo.
In the same spirit, I removed the Changelog page that is semi-generated by the release notes. It now links to just the release notes. We can circle back to doing something like this, but for now a smaller scope is probably better
Requirements (place an
xin each[ ])