Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

docs: fixed duplicative header links in reference - #2120

#2120
Merged
filmaj merged 1 commit into
mainslackapi/bolt-js:mainfrom
luke-toc-links-fixslackapi/bolt-js:luke-toc-links-fixCopy head branch name to clipboard
May 24, 2024
Merged

docs: fixed duplicative header links in reference#2120
filmaj merged 1 commit into
mainslackapi/bolt-js:mainfrom
luke-toc-links-fixslackapi/bolt-js:luke-toc-links-fixCopy head branch name to clipboard

Conversation

@lukegalbraithrussell

@lukegalbraithrussell lukegalbraithrussell commented May 24, 2024

Copy link
Copy Markdown
Contributor

Summary

Header tags were generated automatically and added manually, causing tags with both appended that didn't work .

Tested on local 👍

Requirements

@codecov

codecov Bot commented May 24, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.03%. Comparing base (9d5f4cd) to head (0daae04).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2120   +/-   ##
=======================================
  Coverage   82.03%   82.03%           
=======================================
  Files          18       18           
  Lines        1536     1536           
  Branches      442      442           
=======================================
  Hits         1260     1260           
  Misses        178      178           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@filmaj filmaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@filmaj
filmaj merged commit 53f8998 into main May 24, 2024
@filmaj
filmaj deleted the luke-toc-links-fix branch May 24, 2024 16:37
This was referenced Sep 13, 2024
This was referenced Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.