Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat(cli): support force push - #6

#6
Closed
terminalchai wants to merge 1 commit into
skrun-dev:mainskrun-dev/skrun:mainfrom
terminalchai:feature/cli-push-forceterminalchai/skrun:feature/cli-push-forceCopy head branch name to clipboard
Closed

feat(cli): support force push#6
terminalchai wants to merge 1 commit into
skrun-dev:mainskrun-dev/skrun:mainfrom
terminalchai:feature/cli-push-forceterminalchai/skrun:feature/cli-push-forceCopy head branch name to clipboard

Conversation

@terminalchai

@terminalchai terminalchai commented Mar 31, 2026

Copy link
Copy Markdown

Summary

  • add --force to skrun push and pass it through the CLI registry client as force=true
  • allow the registry API/service to overwrite an existing version when forced instead of returning 409
  • cover the new overwrite path in CLI client tests, API route tests, and service tests, and document the flag in the CLI reference

Testing

  • pnpm build
  • pnpm test
  • pnpm exec biome check packages/cli/src/commands/push.ts packages/cli/src/utils/registry-client.ts packages/cli/src/utils/registry-client.test.ts packages/api/src/db/memory.ts packages/api/src/services/registry.ts packages/api/src/services/registry.test.ts packages/api/src/routes/registry.ts packages/api/src/routes/registry.test.ts docs/cli.md

@terminalchai terminalchai mentioned this pull request Mar 31, 2026
Closed
@Tarcroi

Tarcroi commented Mar 31, 2026

Copy link
Copy Markdown

Thanks for the quick follow-up! Will review in detail later this week.

@Tarcroi

Tarcroi commented Apr 12, 2026

Copy link
Copy Markdown

Apologies for the slow response — we were heads-down on Phase 2 features. Your PR is very welcome and we want to merge it. We just need a rebase on latest main since the codebase has changed quite a bit. Thanks for your patience!

@terminalchai
terminalchai force-pushed the feature/cli-push-force branch from 06ff2e4 to a892519 Compare April 14, 2026 21:20
@Tarcroi

Tarcroi commented Jun 7, 2026

Copy link
Copy Markdown

Hi @terminalchai — thanks again for the PR! 🙏

We're going to pass on skrun push --force. It runs against a core design choice: a published version is meant to stay stable, so that callers who pin a version (POST /run with a version) don't silently get different behavior — letting push overwrite a version in place would break exactly that guarantee.

The supported way to replace a bad version is delete-then-repush: remove the version via the per-version delete endpoint (DELETE /api/agents/:ns/:name/versions/:version), then skrun push again. So an in-place overwrite flag isn't a direction we want to take.

Genuinely appreciate the contribution and the time you put in — closing this PR and the linked issue (#2). Hope to see more from you. 🙌

@Tarcroi Tarcroi closed this Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@terminalchai @Tarcroi
Morty Proxy This is a proxified and sanitized view of the page, visit original site.