Fix @Observable property writes skipped when new value is == old value - #25
#25Merged
marcprux merged 1 commit intoJul 25, 2026
skiptools:mainskiptools/skip-model:mainfrom
dfabulich:observed-referential-equalitydfabulich/skip-model:observed-referential-equalityCopy head branch name to clipboard
Merged
Fix @Observable property writes skipped when new value is == old value#25marcprux merged 1 commit intoskiptools:mainskiptools/skip-model:mainfrom dfabulich:observed-referential-equalitydfabulich/skip-model:observed-referential-equalityCopy head branch name to clipboard
@Observable property writes skipped when new value is == old value#25marcprux merged 1 commit into
skiptools:mainskiptools/skip-model:mainfrom
dfabulich:observed-referential-equalitydfabulich/skip-model:observed-referential-equalityCopy head branch name to clipboard
Conversation
Compose `mutableStateOf` uses structural equality by default, so assigning a new dictionary (or other collection) to an `@Observable` property was ignored when `Equatable` said nothing changed. Now, we use referential equality, so assignment always updates the backing state. Fixes skiptools#24
dfabulich
force-pushed
the
observed-referential-equality
branch
from
July 25, 2026 19:02
5f5cb6c to
91ef61b
Compare
Member
|
Sorry for the delayed review — this fell off the radar somehow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compose
mutableStateOfuses structural equality by default, so assigning a new dictionary (or other collection) to an@Observableproperty was ignored whenEquatablesaid nothing changed.Now, we use referential equality, so assignment always updates the backing state.
Fixes #24
Skip Pull Request Checklist:
swift testTested using skiptools/skipapp-showcase#110