Simple prototype of scientific number notation support#706
Closed
ony wants to merge 1 commit into
Closed
Simple prototype of scientific number notation support#706ony wants to merge 1 commit into
ony wants to merge 1 commit into
Conversation
ony
force-pushed
the
feature/scientific
branch
from
February 10, 2018 07:57
897e90d to
bb5aeb5
Compare
Owner
|
Looking good, with this patch hledger successfully parses coinbase CSV when it contains scientific notation. Nice tests. I expect some corner cases remain to be clarified like you mentioned on #704, but let's wait and see. The "some strange effect of default" issue seems to be unrelated to this PR so could be removed, I have opened #716 for it. This should be mentioned in Amounts; let me know if you want help with that. |
simonmichael
pushed a commit
that referenced
this pull request
Mar 31, 2018
simonmichael
added a commit
that referenced
this pull request
Mar 31, 2018
simonmichael
added a commit
that referenced
this pull request
Mar 31, 2018
simonmichael
added a commit
that referenced
this pull request
Mar 31, 2018
simonmichael
added a commit
that referenced
this pull request
Mar 31, 2018
simonmichael
added a commit
that referenced
this pull request
Mar 31, 2018
Owner
|
Merged as b377bf etc., thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is follow-up change for #704