Handle null values while parsing double and float#57
Open
Szczurowsky wants to merge 1 commit into
simdjson:mainsimdjson/simdjson-java:mainfrom
Szczurowsky:handle-null-valuesSzczurowsky/simdjson-java:handle-null-valuesCopy head branch name to clipboard
Open
Handle null values while parsing double and float#57Szczurowsky wants to merge 1 commit intosimdjson:mainsimdjson/simdjson-java:mainfrom Szczurowsky:handle-null-valuesSzczurowsky/simdjson-java:handle-null-valuesCopy head branch name to clipboard
Szczurowsky wants to merge 1 commit into
simdjson:mainsimdjson/simdjson-java:mainfrom
Szczurowsky:handle-null-valuesSzczurowsky/simdjson-java:handle-null-valuesCopy head branch name to clipboard
Conversation
Member
|
Thanks for the PR. A couple of comments:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you try to parse JSON that has field with type (for ex.) double and value of that field is null, then it throws and exception.
That PR will allow such value for Double and Float, since they have value NaN that fits for that purpose.