Update dates and readme#2
Merged
Merged
Conversation
emteknetnz
force-pushed
the
pulls/main/dates
branch
7 times, most recently
from
August 4, 2025 05:06
298dc88 to
aa83862
Compare
emteknetnz
marked this pull request as ready for review
August 4, 2025 05:07
emteknetnz
commented
Aug 4, 2025
emteknetnz
commented
Aug 4, 2025
emteknetnz
force-pushed
the
pulls/main/dates
branch
2 times, most recently
from
August 4, 2025 05:17
78695c0 to
d926447
Compare
GuySartorelli
requested changes
Aug 5, 2025
emteknetnz
force-pushed
the
pulls/main/dates
branch
from
August 5, 2025 05:07
d926447 to
393fddb
Compare
GuySartorelli
requested changes
Aug 5, 2025
emteknetnz
force-pushed
the
pulls/main/dates
branch
2 times, most recently
from
August 5, 2025 22:42
f940854 to
7fb3909
Compare
GuySartorelli
requested changes
Aug 5, 2025
GuySartorelli
left a comment
Member
There was a problem hiding this comment.
Just one tiny change. I normally wouldn't hold off merging just for a comment typo, but this one changes the meaning of the comment.
emteknetnz
force-pushed
the
pulls/main/dates
branch
from
August 5, 2025 23:02
7fb3909 to
dde898a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue https://github.com/silverstripeltd/product-issues/issues/908
Adds date update instructions and validation inline with the release policy
The +1 day dates to ensure we fulfill "6 months of support" or "1 year of support" are a little bit annoying because something like "2025-10-20" 12 months in the future will be "2026-10-21", though I've added validation around this to ensure it's updated correctly
The other way we e could have done this is not do the +1 in data.json, instead do it on dot org, however there the JS logic uses the intuitive >= type of operators so that at midnight when the day flip overs whatever support level starts, so I think it's much more intuitive to do in data.json