Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Added code to CreateReleaseNotesHtml to set the charset in a metadata… - #72

#72
Merged
tombogle merged 3 commits into
mastersillsdev/SIL.BuildTasks:masterfrom
set-charsetsillsdev/SIL.BuildTasks:set-charsetCopy head branch name to clipboard
Feb 22, 2025
Merged

Added code to CreateReleaseNotesHtml to set the charset in a metadata…#72
tombogle merged 3 commits into
mastersillsdev/SIL.BuildTasks:masterfrom
set-charsetsillsdev/SIL.BuildTasks:set-charsetCopy head branch name to clipboard

Conversation

@tombogle

@tombogle tombogle commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

… element in the HTML head so that special characters such as the TM mark do not render as garbled text


This change is Reviewable

… element in the HTML head so that special characters such as the TM mark do not render as garbled text
@tombogle tombogle added the enhancement New feature or request label Feb 13, 2025
@tombogle tombogle self-assigned this Feb 13, 2025
@github-actions

github-actions Bot commented Feb 13, 2025

Copy link
Copy Markdown

Test Results

  4 files  ±0   46 suites  +2   1m 1s ⏱️ +41s
195 tests +2  195 ✅ +2  0 💤 ±0  0 ❌ ±0 
390 runs  +4  388 ✅ +4  2 💤 ±0  0 ❌ ±0 

Results for commit abb9de3. ± Comparison against base commit 7b8439f.

This pull request removes 4 and adds 6 tests. Note that renamed tests count towards both.
HtmlWithNoReleaseNotesElementIsCompletelyReplaced
HtmlWithReleaseNotesElementHasOnlyReleaseNoteElementChanged
HtmlWithReleaseNotesElementWithContentsIsChanged
RemovesKACHead
HtmlWithNoReleaseNotesElement_IsCompletelyReplaced("ISO-8859-1")
HtmlWithNoReleaseNotesElement_IsCompletelyReplaced("UTF-8")
HtmlWithNoReleaseNotesElement_IsCompletelyReplaced(null)
HtmlWithReleaseNotesElementWithContents_IsChanged
HtmlWithReleaseNotesElement_HasOnlyReleaseNoteElementChanged
RemovesKeepAChangelogHead

♻️ This comment has been updated with latest results.

/// and replace it with the current release notes.
/// The developer-oriented and [Unreleased] beginning will be removed from a Keep a Changelog style changelog.
/// If the HTML file already exists, the task will look for a section with
/// `class="<see cref="kReleaseNotesClassName"/>>"` and replace it with the current release

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// `class="<see cref="kReleaseNotesClassName"/>>"` and replace it with the current release
/// `class="<see cref="kReleaseNotesClassName"/>"` and replace it with the current release

@tombogle
tombogle merged commit 3690e20 into master Feb 22, 2025
@tombogle
tombogle deleted the set-charset branch February 22, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.