fix: add URL validation in summarize_site_validation.py#2934
Open
orbisai0security wants to merge 1 commit into
sherlock-project:mastersherlock-project/sherlock:masterfrom
orbisai0security:fix-v-002-defusedxml-xxe-protectionorbisai0security/sherlock:fix-v-002-defusedxml-xxe-protectionCopy head branch name to clipboard
Open
fix: add URL validation in summarize_site_validation.py#2934orbisai0security wants to merge 1 commit intosherlock-project:mastersherlock-project/sherlock:masterfrom orbisai0security:fix-v-002-defusedxml-xxe-protectionorbisai0security/sherlock:fix-v-002-defusedxml-xxe-protectionCopy head branch name to clipboard
orbisai0security wants to merge 1 commit into
sherlock-project:mastersherlock-project/sherlock:masterfrom
orbisai0security:fix-v-002-defusedxml-xxe-protectionorbisai0security/sherlock:fix-v-002-defusedxml-xxe-protectionCopy head branch name to clipboard
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
devel/summarize_site_validation.py.Vulnerability
V-002devel/summarize_site_validation.py:62Description: The script devel/summarize_site_validation.py reads an XML file from a user-supplied path (sys.argv[1]) and parses it using Python's standard xml library. The standard xml library does not protect against XML entity expansion attacks (Billion Laughs / XML Bomb) or XXE (XML External Entity) attacks. An attacker can supply a crafted XML file with deeply nested entity references that expand exponentially, consuming all available CPU and memory and causing a denial of service. Additionally, XXE attacks can be used to read local files (e.g., /etc/passwd, private SSH keys) or make SSRF requests via external entity references.
Changes
devel/summarize_site_validation.pyVerification
Automated security fix by OrbisAI Security