Fix --wrap=word leaking a leading space onto the continuation line#3832
Open
upuddu wants to merge 2 commits into
sharkdp:mastersharkdp/bat:masterfrom
upuddu:fix/word-wrap-leading-spaceupuddu/bat:fix/word-wrap-leading-spaceCopy head branch name to clipboard
Open
Fix --wrap=word leaking a leading space onto the continuation line#3832upuddu wants to merge 2 commits intosharkdp:mastersharkdp/bat:masterfrom upuddu:fix/word-wrap-leading-spaceupuddu/bat:fix/word-wrap-leading-spaceCopy head branch name to clipboard
upuddu wants to merge 2 commits into
sharkdp:mastersharkdp/bat:masterfrom
upuddu:fix/word-wrap-leading-spaceupuddu/bat:fix/word-wrap-leading-spaceCopy head branch name to clipboard
Conversation
When a word ended exactly at the terminal width, the separating whitespace was the character that triggered the wrap. The buffered word was emitted correctly, but the triggering space was then pushed onto the next visual line, producing a spurious leading space. Consume the separating whitespace when it triggers the wrap.
keith-hall
approved these changes
Jul 7, 2026
keith-hall
enabled auto-merge
July 7, 2026 19:34
Author
|
Heads-up: the two red checks here ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a word ends exactly at the terminal width, the separating whitespace is the character that triggers the wrap, and it was being pushed onto the next visual line as a spurious leading space. This consumes that whitespace when it triggers the wrap.