Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add VimHelp.sublime-syntax and its test#2366

Merged
sharkdp merged 1 commit into
sharkdp:mastersharkdp/bat:masterfrom
Freed-Wu:vimhelpCopy head branch name to clipboard
Nov 4, 2022
Merged

Add VimHelp.sublime-syntax and its test#2366
sharkdp merged 1 commit into
sharkdp:mastersharkdp/bat:masterfrom
Freed-Wu:vimhelpCopy head branch name to clipboard

Conversation

@Freed-Wu

@Freed-Wu Freed-Wu commented Oct 12, 2022

Copy link
Copy Markdown
Contributor

screen-2022-10-30-13-22-55

@sharkdp

sharkdp commented Oct 30, 2022

Copy link
Copy Markdown
Owner

Please also follow the usual practices here (see comments in your other PR)

@sharkdp

sharkdp commented Oct 30, 2022

Copy link
Copy Markdown
Owner

Also, I'm not sure if this satisfies our policies for syntax inclusion: https://github.com/sharkdp/bat/blob/master/doc/assets.md#Criteria-for-inclusion-of-new-syntaxes

@Freed-Wu

Copy link
Copy Markdown
Contributor Author

More than 10,000 downloads at Package Control

I think sublime users have no any need to view a vimhelp file 😄

@sharkdp

sharkdp commented Oct 30, 2022

Copy link
Copy Markdown
Owner

Fair point, but I also fail to see why someone would want to view a vim help text in bat, and not in vim directly

@Freed-Wu

Copy link
Copy Markdown
Contributor Author

less is a pager and vim is an editor. If users just want to take a look at a file, they can just less it.

@sharkdp

sharkdp commented Nov 2, 2022

Copy link
Copy Markdown
Owner

Yeah but... if I feel the need to look at vims help texts, I'm usually already inside vim - no?

@Freed-Wu

Freed-Wu commented Nov 3, 2022

Copy link
Copy Markdown
Contributor Author

if I feel the need to look at vims help texts, I'm usually already inside vim

Maybe any one who need to look at vimhelp install vim in their machine and can
use vim to look at helpfile, however, it only be convenient for those helpfiles
have been installed. For a vim plugin users don't ensure should they install,
before installation, use less to see it is also a reasonable situation.

BTW, I think vimhelp for vim is like orgmode for emacs, and bat have supported
orgmode, so perhaps vimhelp can be supported, too.

@sharkdp

sharkdp commented Nov 4, 2022

Copy link
Copy Markdown
Owner

Ok 😄

Thank you for your contribution. In the future, please open an issue first before you invest a lot of time in things that might not be accepted into bat in the end.

@sharkdp
sharkdp merged commit accc1b6 into sharkdp:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.