Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Improve Manpage.sublime-syntax, Fix #2353#2364

Merged
Enselic merged 2 commits into
sharkdp:mastersharkdp/bat:masterfrom
Freed-Wu:manCopy head branch name to clipboard
Oct 17, 2022
Merged

Improve Manpage.sublime-syntax, Fix #2353#2364
Enselic merged 2 commits into
sharkdp:mastersharkdp/bat:masterfrom
Freed-Wu:manCopy head branch name to clipboard

Conversation

@Freed-Wu

@Freed-Wu Freed-Wu commented Oct 9, 2022

Copy link
Copy Markdown
Contributor

Screenshot from 2022-10-09 13-56-09

It still exists many problems, such as man fzf

Screenshot from 2022-10-09 14-00-35

Should we highlight +x before or? Case-XXX shouldn't be highlighted, right?

Screenshot from 2022-10-09 14-01-43

Wrong N[,...].

How to distinguish the following -.s?

Screenshot from 2022-10-09 14-02-42
Screenshot from 2022-10-09 14-03-12

@keith-hall

Copy link
Copy Markdown
Collaborator

It would be great to add some "highlighted file" tests for this. Basically just putting man fzf into a file in https://github.com/sharkdp/bat/tree/master/tests/syntax-tests/source/Manpage and running https://github.com/sharkdp/bat/blob/master/tests/syntax-tests/update.sh afterwards and including both files in the PR. This will enable us to see how future changes affect the highlighting, to help prevent regressions.

@Freed-Wu

Copy link
Copy Markdown
Contributor Author

It would be great to add some "highlighted file" tests.

Done.

@keith-hall keith-hall left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You can also optionally update the changelog so others will know what you fixed :)

@Freed-Wu

Copy link
Copy Markdown
Contributor Author

update the changelog

Fixed.

@Enselic
Enselic merged commit f215d07 into sharkdp:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.