Add .mts and .cts to TypeScript file extensions#2236
Merged
Merged
Add .mts and .cts to TypeScript file extensions#2236
.mts and .cts to TypeScript file extensions#2236Conversation
Enselic
requested changes
Aug 12, 2022
Enselic
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the contribution! Do you think we can upstream this change?
The file you changed is converted from a .tmLanguage, which makes maintenance a bit of a headache. I think we need to at least add some basic regression tests if we are to patch this file ourselves. Not sure what other maintainers think.
See https://github.com/sharkdp/bat/blob/master/doc/assets.md for some general pointers on adding tests.
Owner
|
@kidonng Any update on this? |
Owner
|
The upstream repository seems to be unmaintained (microsoft/TypeScript-Sublime-Plugin#786). So let's just patch this file and put a simple regression test in place. Updated this PR accordingly. |
sharkdp
approved these changes
Sep 4, 2022
Enselic
approved these changes
Sep 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are TypeScript counterparts of Node.js
.mjsand.cjsfile extensions.See also:
mtsandctsTypeScript extensions github-linguist/linguist#5905.mtsand.ctsfiles starship/starship#3734