fix: convert port to number type - #185
#185Open
hiramatsutaku wants to merge 1 commit into
serverless-appsync:betaserverless-appsync/serverless-appsync-simulator:betafrom
hiramatsutaku:fix-port-increment-bug-on-multiple-apishiramatsutaku/serverless-appsync-simulator:fix-port-increment-bug-on-multiple-apisCopy head branch name to clipboard
Open
fix: convert port to number type#185hiramatsutaku wants to merge 1 commit intoserverless-appsync:betaserverless-appsync/serverless-appsync-simulator:betafrom hiramatsutaku:fix-port-increment-bug-on-multiple-apishiramatsutaku/serverless-appsync-simulator:fix-port-increment-bug-on-multiple-apisCopy head branch name to clipboard
hiramatsutaku wants to merge 1 commit into
serverless-appsync:betaserverless-appsync/serverless-appsync-simulator:betafrom
hiramatsutaku:fix-port-increment-bug-on-multiple-apishiramatsutaku/serverless-appsync-simulator:fix-port-increment-bug-on-multiple-apisCopy head branch name to clipboard
Conversation
- If port is specified from the environment variable, it may be string type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using multiple APIs, port is incremented.(See: #92)
However, when I specified port from the environment variable, it became a string and could not be incremented, resulting in the following error.
So, I fixed this even if port/wsPort is specified from an environment variable.