test(esbuild): fix invoke-local outExtension test on Windows#13743
Merged
czubocha merged 1 commit intoJul 24, 2026
mainserverless/serverless:mainfrom
fix/esbuild-invoke-local-test-windowsserverless/serverless:fix/esbuild-invoke-local-test-windowsCopy head branch name to clipboard
Merged
test(esbuild): fix invoke-local outExtension test on Windows#13743czubocha merged 1 commit intomainserverless/serverless:mainfrom fix/esbuild-invoke-local-test-windowsserverless/serverless:fix/esbuild-invoke-local-test-windowsCopy head branch name to clipboard
czubocha merged 1 commit into
mainserverless/serverless:mainfrom
fix/esbuild-invoke-local-test-windowsserverless/serverless:fix/esbuild-invoke-local-test-windowsCopy head branch name to clipboard
Conversation
The child-process driver imported the plugin via a raw filesystem path, which Node's ESM loader rejects as an import specifier on Windows (ERR_UNSUPPORTED_ESM_URL_SCHEME), producing empty stdout and failing all four assertions. Import via a file:// URL and surface driver startup errors instead of exiting silently.
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe invoke-local extension test now converts the plugin path to a ChangesInvoke-local plugin loading
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
invoke localoutExtensionunit test on Windows, where all four assertions failed with empty outputRoot cause
The test spawns a Node child process whose driver script imported the plugin through a raw filesystem path. On Windows a drive-letter path (
C:\...) is not a valid ESM import specifier — Node's loader throwsERR_UNSUPPORTED_ESM_URL_SCHEMEat module evaluation, before the driver prints anything, so the child produced empty stdout and every assertion saw"". On POSIX the absolute path was accepted as a specifier, so the test passed on Linux and macOS.Fix
file://URL (pathToFileURL(...).href), which is a valid specifier on all platformstryblock and print a diagnostic on failure, so a future startup error surfaces a code instead of silently exiting with empty outputTest plan
test/unit/lib/plugins/aws/invoke-local/out-extension.test.jspasses (4/4); lint and prettier cleanERR_UNSUPPORTED_ESM_URL_SCHEME(reproducing the Windows failure) while thefile://URL loads correctlyNo production code changes; test-only.
Summary by CodeRabbit
.mjs,.cjs, and JavaScript module formats.