packages/core/test/unit/instance/build.test.js (1)

99-132: Test doesn't exercise the fix in _initValues.

This test uses timestamps: false with manually defined timestamp fields. With this configuration, createdAt/updatedAt are not in readOnlyAttributeNames, so the new code at lines 268-280 in model.js isn't triggered.

The fix addresses the case where:

1. Timestamps are enabled (the default) — so createdAt/updatedAt are in readOnlyAttributeNames
2. isNewRecord: false is passed to build() — triggering the new code path

Consider adding a test that verifies the actual fix:

💡 Suggested additional test

+    it('should retain timestamps when rebuilding with isNewRecord: false', () => {
+      const User = current.define('User', {
+        username: DataTypes.STRING,
+      }); // timestamps: true by default
+
+      const now = new Date();
+      now.setMilliseconds(0);
+
+      const instance = User.build(
+        {
+          username: 'user-name',
+          createdAt: now,
+          updatedAt: now,
+        },
+        { isNewRecord: false },
+      );
+
+      const json = instance.toJSON();
+      const rebuiltInstance = User.build(json, { isNewRecord: false });
+
+      expect(rebuiltInstance.get('createdAt')).to.be.an.instanceof(Date);
+      expect(rebuiltInstance.get('updatedAt')).to.be.an.instanceof(Date);
+      expect(rebuiltInstance.get('createdAt').getTime()).to.equal(now.getTime());
+      expect(rebuiltInstance.get('updatedAt').getTime()).to.equal(now.getTime());
+    });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/core/test/unit/instance/build.test.js` around lines 99 - 132, Add a
new unit test in build.test.js that exercises the _initValues code path by using
a model with default timestamps (do not set timestamps:false), defining
createdAt and updatedAt attributes, building an instance with isNewRecord: false
and providing createdAt/updatedAt values (use a Date with milliseconds zeroed),
then assert the rebuilt instance preserves those dates (instances of Date, equal
getTime()) and that dataValues contains createdAt/updatedAt; this ensures the
branch that checks readOnlyAttributeNames (the new logic in _initValues) is
actually tested when timestamps are enabled and build() is called with
isNewRecord:false.