Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Improve CI checks#34

Merged
maelanleborgne merged 3 commits into
sensiolabs:mainsensiolabs/AssetMapperTypeScriptBundle:mainfrom
maelanleborgne:feature/add-phpstanmaelanleborgne/AssetMapperTypeScriptBundle:feature/add-phpstanCopy head branch name to clipboard
Feb 20, 2024
Merged

Improve CI checks#34
maelanleborgne merged 3 commits into
sensiolabs:mainsensiolabs/AssetMapperTypeScriptBundle:mainfrom
maelanleborgne:feature/add-phpstanmaelanleborgne/AssetMapperTypeScriptBundle:feature/add-phpstanCopy head branch name to clipboard

Conversation

@maelanleborgne
Copy link
Copy Markdown
Contributor

@maelanleborgne maelanleborgne commented Feb 19, 2024 •
edited
Loading

  • Add phpstan lvl 8 to CI
  • Fix code to pass phpstan check
  • Upgrade phpunit to 10.5 + get rid of symfony/phpunit-bridge
  • Add php 8.3 to the list of tested versions

@maelanleborgne maelanleborgne changed the title Add phpstan lvl 8 to CI + fix code to pass Improve CI checks Feb 19, 2024
Jean-Beru
Jean-Beru reviewed Feb 19, 2024
View reviewed changes
Comment thread src/SensiolabsTypeScriptBundle.php Outdated
Comment thread src/AssetMapper/TypeScriptPublicPathAssetPathResolver.php
ktherage
ktherage reviewed Feb 20, 2024
View reviewed changes
Comment thread composer.json Outdated
Comment thread tests/fixtures/other_dir/file_in_other_dir
@maelanleborgne maelanleborgne merged commit a7bd265 into sensiolabs:main Feb 20, 2024
@maelanleborgne maelanleborgne deleted the feature/add-phpstan branch March 14, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jean-Beru Jean-Beru Jean-Beru left review comments

+1 more reviewer

@ktherage ktherage ktherage left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maelanleborgne @Jean-Beru @ktherage
Morty Proxy This is a proxified and sanitized view of the page, visit original site.