Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Install prism with non superuser account #364

Merged
thinkingserious merged 3 commits into
sendgrid:mastersendgrid/sendgrid-python:masterfrom
meahow:issue_311_prismmeahow/sendgrid-python:issue_311_prismCopy head branch name to clipboard
Oct 22, 2017
Merged

Install prism with non superuser account #364
thinkingserious merged 3 commits into
sendgrid:mastersendgrid/sendgrid-python:masterfrom
meahow:issue_311_prismmeahow/sendgrid-python:issue_311_prismCopy head branch name to clipboard

Conversation

@meahow

@meahow meahow commented Oct 7, 2017

Copy link
Copy Markdown
Contributor

This changes the install method used in unittests to test/prism.sh script.
prism.sh downloads latest stable (pre 2.0alpha - currently v0.6) and installs it into ~/bin directory.

Unittests will check for prism command in the PATH and few known locations (among them ~/bin dir) and if prism is not found, it will launch the prism script to install it and use the newly installed binary.

CONTRIBUTING page was updated with new procedure info

Fixes #311

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 7, 2017
@SendGridDX

SendGridDX commented Oct 7, 2017

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

meahow added 3 commits October 7, 2017 15:01
- test/prism.sh is used in test_sendgrid.py
- default dest path in test/prism.sh changed to ~/bin
- test_sendgrid.py checks for prism in PATH and known locations
- if it's not found, it will try to install it with test/prism.sh script
@meahow meahow changed the title Fixes #311 Install prism with non superuser account Oct 7, 2017
@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio difficulty: hard fix is hard in difficulty hacktoberfest labels Oct 16, 2017
@thinkingserious thinkingserious merged commit e6532ef into sendgrid:master Oct 22, 2017
@thinkingserious

Copy link
Copy Markdown
Contributor

Hello @meahow,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: hard fix is hard in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.