Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Improve code quality#250

Merged
SendGridDX merged 5 commits into
sendgrid:mastersendgrid/sendgrid-python:masterfrom
andriisoldatenko:fix-pep8-errorsandriisoldatenko/sendgrid-python:fix-pep8-errorsCopy head branch name to clipboard
Mar 29, 2017
Merged

Improve code quality#250
SendGridDX merged 5 commits into
sendgrid:mastersendgrid/sendgrid-python:masterfrom
andriisoldatenko:fix-pep8-errorsandriisoldatenko/sendgrid-python:fix-pep8-errorsCopy head branch name to clipboard

Conversation

@andriisoldatenko

@andriisoldatenko andriisoldatenko commented Nov 10, 2016

Copy link
Copy Markdown
Contributor

Summary

According to CONTRIBUTING code should pass all pep8 and flake8 errors

On master branch we can see

(python-sedgrid) ~/sendgrid-python$ flake8 . | wc -l
1201
OR
pep8 . | wc -l
1033

The goal of this PR to fix all errors.

After this PR merged:

flake8 test/ | wc -l 
test/test_mail.py:212:80: E501 line too long (3359 > 79 characters)

Checks on sendgrid/ module:

flake8 sendgrid/ wc -l

Unit tests:

----------------------------------------------------------------------
Ran 238 tests in 32.903s

OK

Install checking tools:

pip install flake8 pep8 isort

@andriisoldatenko

andriisoldatenko commented Nov 10, 2016

Copy link
Copy Markdown
Contributor Author

@thinkingserious Please review.
cc @vananabu

@thinkingserious

thinkingserious commented Nov 10, 2016

Copy link
Copy Markdown
Contributor

Awesome @andriisoldatenko!

Could you please sign our CLA so I can review and merge? Thanks!

@thinkingserious thinkingserious added status: cla needed status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap labels Nov 10, 2016
@andriisoldatenko

andriisoldatenko commented Nov 15, 2016

Copy link
Copy Markdown
Contributor Author

@thinkingserious done.

@thinkingserious

thinkingserious commented Nov 15, 2016

Copy link
Copy Markdown
Contributor

Hi @andriisoldatenko,

Could you please fix the conflicts in test/test_sendgrid.py? Thanks!

@andriisoldatenko

andriisoldatenko commented Nov 15, 2016

Copy link
Copy Markdown
Contributor Author

@thinkingserious done.

@andriisoldatenko

andriisoldatenko commented Nov 16, 2016

Copy link
Copy Markdown
Contributor Author

@thinkingserious Can you please review again. Thanks

@SendGridDX SendGridDX merged commit beed6e4 into sendgrid:master Mar 29, 2017
@SendGridDX

SendGridDX commented Mar 29, 2017

Copy link
Copy Markdown

Hi @andriisoldatenko,

Thanks again for the PR, please take a moment to fill out this form so that we may send you some swag :)

thinkingserious added a commit that referenced this pull request Mar 29, 2017
@thinkingserious
Version Bump v3.6.4: #250 Improve Code Quaility
4d34108
thinkingserious added a commit that referenced this pull request Mar 29, 2017
@thinkingserious
Version Bump v3.6.4: #250 Improve code quality
629377e
This was referenced Mar 29, 2017
Closed
Closed
Closed
Merged
@fabaff fabaff mentioned this pull request Mar 31, 2017
Merged
@pyup-bot pyup-bot mentioned this pull request Apr 17, 2017
Merged
@pyup-bot pyup-bot mentioned this pull request May 1, 2017
Closed
This was referenced Jun 5, 2017
Closed
Closed
@pyup-bot pyup-bot mentioned this pull request Jun 19, 2017
Closed
@pyup-bot pyup-bot mentioned this pull request Jul 3, 2017
Closed
@pyup-bot pyup-bot mentioned this pull request Jul 17, 2017
Closed
@pyup-bot pyup-bot mentioned this pull request Aug 7, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andriisoldatenko @thinkingserious @SendGridDX
Morty Proxy This is a proxified and sanitized view of the page, visit original site.