Refactored attachments(...) in sendgrid/helpers/inbound/parse.py, doc…#211
Merged
thinkingserious merged 2 commits intoAug 31, 2016
sendgrid:mastersendgrid/sendgrid-python:masterfrom
LiYChristopher:parse_refactorLiYChristopher/sendgrid-python:parse_refactorCopy head branch name to clipboard
Merged
Refactored attachments(...) in sendgrid/helpers/inbound/parse.py, doc…#211thinkingserious merged 2 commits intosendgrid:mastersendgrid/sendgrid-python:masterfrom LiYChristopher:parse_refactorLiYChristopher/sendgrid-python:parse_refactorCopy head branch name to clipboard
thinkingserious merged 2 commits into
sendgrid:mastersendgrid/sendgrid-python:masterfrom
LiYChristopher:parse_refactorLiYChristopher/sendgrid-python:parse_refactorCopy head branch name to clipboard
Conversation
…strings under func. definitions
thinkingserious
added a commit
that referenced
this pull request
Aug 31, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests all passed locally;
Within sendgrid/helpers/inbound/parse.py - moved doc strings to be under function definitions
broke up
def attachments(...)into two individual private functions, so it's a bit less cumbersome and can be individually tested better