Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

add asyncio support#162

Closed
mrbox wants to merge 1 commit into
mastersendgrid/sendgrid-python:masterfrom
unknown repositoryCopy head branch name to clipboard
Closed

add asyncio support#162
mrbox wants to merge 1 commit into
mastersendgrid/sendgrid-python:masterfrom
unknown repositoryCopy head branch name to clipboard

Conversation

@mrbox

@mrbox mrbox commented Feb 11, 2016

Copy link
Copy Markdown

Add possibility to use library with python asyncio library.

@thinkingserious

Copy link
Copy Markdown
Contributor

Hello @mrbox,

With our v2.0.0 it looks like this code would require some re-writing, but it should not be too much. That said, before you look into updating this code, a couple of notes:

  1. This is not a feature that we will add to the core of the library
  2. Instead, we would consider this a "helper" function
  3. We will be adding a "helpers" folder at the root level, where these sorts of enhancements would live

If you are interested in reworking this code let us know, if not, we will add it to our backlog.

In either case, shoot us an email at dx@sendgrid.com, we'd love to swag you out!

Thanks!

@thinkingserious

Copy link
Copy Markdown
Contributor

Here is the issue to follow regarding the helpers: #169

@thinkingserious thinkingserious added the type: community enhancement feature request not on Twilio's roadmap label Mar 3, 2016
@mrbox

mrbox commented Mar 3, 2016

Copy link
Copy Markdown
Author

@thinkingserious sure I'm interested in reworking, it shouldn't be a big change- please ping me when the helpers module will be available so I can follow up :)

@thinkingserious

Copy link
Copy Markdown
Contributor

@mrbox

The replacement library is now ready: https://github.com/sendgrid/sendgrid-python/tree/v3beta

If you have any pull requests, please check out that branch and we will need a signed CLA.

@thinkingserious

Copy link
Copy Markdown
Contributor

Hello @mrbox,

Just check in :)

@andriisoldatenko

Copy link
Copy Markdown
Contributor

@mrbox @thinkingserious If you want guys I can continue working on this PR

@thinkingserious

Copy link
Copy Markdown
Contributor

@andriisoldatenko that sounds good to me :)

@mrbox thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: community enhancement feature request not on Twilio's roadmap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.