Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: correct the LICENSE.md link in pom.xml#109

Merged
childish-sambino merged 4 commits into
sendgrid:mastersendgrid/java-http-client:masterfrom
crweiner:mastercrweiner/java-http-client:masterCopy head branch name to clipboard
Jul 17, 2020
Merged

fix: correct the LICENSE.md link in pom.xml#109
childish-sambino merged 4 commits into
sendgrid:mastersendgrid/java-http-client:masterfrom
crweiner:mastercrweiner/java-http-client:masterCopy head branch name to clipboard

Conversation

@crweiner

Copy link
Copy Markdown
Contributor

Similar issue to PR #513 in your Java repo. If you have a template to deploy repos, be sure to fix the LICENSE linking errors upstream. 👍

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

The link to the LICENSE file in README.md points to LICENSE.txt when the actual MIT license file is LICENSE.md.

This PR fixes it to be the proper link. 👍

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 25, 2018
@SendGridDX

SendGridDX commented Oct 25, 2018

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@crweiner crweiner changed the title Fix Link to LICENSE.md in README.md Fix Link to LICENSE.md in README.md and pom.xml Oct 26, 2018
@childish-sambino childish-sambino changed the title Fix Link to LICENSE.md in README.md and pom.xml fix: correct the LICENSE.md link in pom.xml Jul 17, 2020
@childish-sambino childish-sambino merged commit 9124e09 into sendgrid:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.