Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC Add link to plot coin segmentation in docstrings and user guide #29890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

miguelcsx
Copy link
Contributor

Reference Issues/PRs

See also #26927

What does this implement/fix? Explain your changes.

This PR enhances the documentation by adding links to usage examples for SpectralClustering. Specifically, it includes references in the docstrings and user guide to the plot_coin_segmentation.py example, which demonstrates a practical application of SpectralClustering.

Copy link

github-actions bot commented Sep 19, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 4035f5f. Link to the linter CI: here

@miguelcsx miguelcsx force-pushed the docs/example-plot-coin-segmentation branch from 4ceedc7 to 0d5a852 Compare September 19, 2024 04:02
sklearn/cluster/_spectral.py Outdated Show resolved Hide resolved
sklearn/cluster/_spectral.py Outdated Show resolved Hide resolved
@miguelcsx miguelcsx force-pushed the docs/example-plot-coin-segmentation branch from 73862f8 to 4e77c8d Compare September 30, 2024 21:27
@miguelcsx
Copy link
Contributor Author

@marenwestermann I moved the example to the spectral clustering function, thanks for the correction 👍

@marenwestermann
Copy link
Member

As mentioned above, it is better to add the link to the assign_labels parameter documentation. Can you please update the PR?

miguelcsx and others added 3 commits October 1, 2024 08:46
- include cluster example in docstrings and the user guide
- removed unnecessary blank line at the end

Co-authored-by: Xiao Yuan <yuanx749@gmail.com>
@miguelcsx miguelcsx force-pushed the docs/example-plot-coin-segmentation branch from 4e77c8d to b494ccd Compare October 1, 2024 15:15
@miguelcsx
Copy link
Contributor Author

@marenwestermann Sorry for my misunderstanding, I already updated it, thanks

sklearn/cluster/_spectral.py Outdated Show resolved Hide resolved
@miguelcsx miguelcsx force-pushed the docs/example-plot-coin-segmentation branch from 5b75c54 to 31d087a Compare October 3, 2024 20:42
sklearn/cluster/_spectral.py Outdated Show resolved Hide resolved
@miguelcsx miguelcsx force-pushed the docs/example-plot-coin-segmentation branch from dc32d1a to 3b60337 Compare October 4, 2024 18:10
@glemaitre glemaitre self-requested a review October 16, 2024 17:23
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a small fix by addressing the last comment from @marenwestermann

The rendering looks OK otherwise. LGTM.

I'll enable auto-merge.

Thanks @miguelcsx

@glemaitre glemaitre enabled auto-merge (squash) October 16, 2024 17:30
@glemaitre glemaitre merged commit 4dc7dbb into scikit-learn:main Oct 16, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.