File tree Expand file tree Collapse file tree 2 files changed +7
-7
lines changed
Filter options
sklearn/linear_model/tests Expand file tree Collapse file tree 2 files changed +7
-7
lines changed
Original file line number Diff line number Diff line change @@ -257,10 +257,10 @@ Changelog
257
257
for the calculation of test scores.
258
258
:pr: `29419 ` by :user: `Shruti Nath <snath-xoc> `.
259
259
260
- - |Fix | :class: `linear_model.RidgeCV ` now properly use predictions the same scale as the
261
- target seen during `fit `. Those predictions are stored in `cv_results_ ` when when
260
+ - |Fix | :class: `linear_model.RidgeCV ` now properly uses predictions on the same scale as
261
+ the target seen during `fit `. These predictions are stored in `cv_results_ ` when
262
262
`scoring != None `. Previously, the predictions were rescaled by the square root of the
263
- sample weights and offset by the mean of the target leading to an incorrect estimate
263
+ sample weights and offset by the mean of the target, leading to an incorrect estimate
264
264
of the score.
265
265
:pr: `29842 ` by :user: `Guillaume Lemaitre <glemaitre> `,
266
266
:user: `Jérôme Dockes <jeromedockes> ` and
Original file line number Diff line number Diff line change @@ -2261,12 +2261,12 @@ def test_ridge_cv_results_predictions(with_sample_weight, fit_intercept, n_targe
2261
2261
"""Check that the predictions stored in `cv_results_` are on the original scale.
2262
2262
2263
2263
The GCV approach works on scaled data: centered by an offset and scaled by the
2264
- squared root of the sample weights. Thus, previous to compute scores, the
2265
- predictions need to be scaled back to the original scale. Those predictions are the
2266
- ones stored in `cv_results_` in `RidgeCV`.
2264
+ square root of the sample weights. Thus, prior to computing scores, the
2265
+ predictions need to be scaled back to the original scale. These predictions are
2266
+ the ones stored in `cv_results_` in `RidgeCV`.
2267
2267
2268
2268
In this test, we check that the internal predictions stored in `cv_results_` are
2269
- equivalent to a naive LOO-CV grid- search with a `Ridge` estimator.
2269
+ equivalent to a naive LOO-CV grid search with a `Ridge` estimator.
2270
2270
2271
2271
Non-regression test for:
2272
2272
https://github.com/scikit-learn/scikit-learn/issues/13998
You can’t perform that action at this time.
0 commit comments