-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
DOC [PST] install page #28336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC [PST] install page #28336
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, I like the way it looks a lot, but no idea on the js side.
I think I may want to postpone this PR - I've found that However I'm kind of having some trouble updating dependencies because of the pandas warning in the new version, and that's why I'm showing the diff in this way. I've thought about merging So after the dependency problem is solved, and if maintainers like what is shown in the video below, I can just revert the reverting commit What do you think about this @adrinjalali? Installing.scikit-learn.scikit-learn.1.5.dev0.documentation.8.-.-.Microsoft.Edge.2024-02-07.13-15-02.mp4 |
I like the idea, this looks quite good too, and better than having custom js for it. Re dependencies, @lesteve would know better. |
You can update your dependencies in your branch, no need to add them in main. Add your dependencies to the doc build in: scikit-learn/build_tools/update_environments_and_lock_files.py Lines 323 to 347 in e8addd7
Add dependencies in the conda section or in the pip section depending where they are available. Update the dependencies only for your doc build (faster):
There may be conflicts in the lock-files but you can sort them like any other conflicts. |
@lesteve Thanks for you reply! As I replied in #28084 (comment), if we do not worry about the conflicts then merging |
This reverts commit d87e7f2.
Why using
|
So the dependency problem is fixed, @glemaitre @thomasjpfan who also commented in the first PR: would you like to take a look when you have time? 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please note that this PR targets the
new_web_theme
branch!Towards #28084. This main task of this PR is to improve the installation grid, with the help of
sphinx-design
tabs. Please note: the primary sidebar should not have shown up. It is a known bug pydata/pydata-sphinx-theme#1662 and I have proposed a solution upstream pydata/pydata-sphinx-theme#1682.