DOC fix wrong indentations in the documentation that lead to undesired blockquotes #28107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Jan 13, 2024
glemaitre
reviewed
Jan 13, 2024
glemaitre
reviewed
Jan 13, 2024
glemaitre
reviewed
Jan 13, 2024
glemaitre
reviewed
Jan 13, 2024
glemaitre
reviewed
Jan 13, 2024
glemaitre
reviewed
Jan 13, 2024
glemaitre
reviewed
Jan 13, 2024
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
reviewed
Jan 13, 2024
glemaitre
reviewed
Jan 13, 2024
glemaitre
reviewed
Jan 13, 2024
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
approved these changes
Jan 13, 2024
|
Thanks for the review @glemaitre! Seems that these are mostly caused by me letting VSCode automatically dedent without double checking (shouldn't have been lazy lol). I've applied your suggested changes and will make sure to double check as well. |
glemaitre
reviewed
Jan 13, 2024
glemaitre
reviewed
Jan 13, 2024
I got trapped as well with this one in the past :) |
|
Merging. I think it would help for the website issue. |
|
Thanks so much! It definitely would. |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jan 17, 2024
…d blockquotes (scikit-learn#28107) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
jeremiedbb
pushed a commit
that referenced
this pull request
Jan 17, 2024
…d blockquotes (#28107) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
This was referenced Feb 9, 2024
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 10, 2024
…d blockquotes (scikit-learn#28107) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
None, or maybe #28084.
What does this implement/fix? Explain your changes.
There are many places in the documentation where we use wrong indentation, leading to blockquotes. Since the current theme does not have a background or other visible styling for blockquotes it cannot really be observed, but if we switch to a theme (e.g.
pydata-sphinx-theme) that does have a background for blockquotes this would be a problem.Theoretically the current changes in this PR should not change the look of the current website, but is intended to solve some of the problems that the work proposed in #28084 may encounter.
This is indeed a huge PR with thousands of lines of modification, but it is mostly (if not all) about fixing indentation, so I hope it is not too hard to review.