TST Fixes test for 32bit wheels #19402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft for now, since I adjust the github action yaml to build the wheel for 32 bit. |
|
I enabled the wheel building to make sure this fix works: https://github.com/scikit-learn/scikit-learn/actions/runs/548822022 |
glemaitre
reviewed
Feb 9, 2021
glemaitre
approved these changes
Feb 9, 2021
This reverts commit 79fc6b6.
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 22, 2021
glemaitre
pushed a commit
that referenced
this pull request
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #19316
What does this implement/fix? Explain your changes.
Non-scaled data and LBFGS do not work well together. This PR
test_partial_dependence_dataframe, which is useful when the preprocessor isNone.max_iterintest_logistic_regression_multi_class_auto.Any other comments?
Tested this locally in docker and osx. I would want to run
cd build, but I rather not use the ARM credits. I think we need to way to only runcd buildon github actions.