Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fixes divide by zero error thrown by _random_choice_csc during a test… #19383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

mabu-dev
Copy link
Contributor

@mabu-dev mabu-dev commented Feb 6, 2021

Reference Issues/PRs

Towards #19334

What does this implement/fix? Explain your changes.

The runtime error was cause by an incorrect order between classes and class probabilities set during the test run. The referenced function in random.py is fine.

@reshamas
Copy link
Member

reshamas commented Feb 6, 2021

#DataUmbrella sprint
cc: @Mariam-ke

Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmarmo
Copy link
Contributor

cmarmo commented Feb 9, 2021

Hi @mabu-dev, thanks for your pull request! @adrinjalali do you mind having a look at it? this is from the Umbrella sprint and merging it will move forward #19334. Thanks a lot!

@adrinjalali adrinjalali merged commit c3f647a into scikit-learn:main Feb 9, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.