Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix misuse of self.partial_fit in Birch #19231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2021
Merged

Fix misuse of self.partial_fit in Birch #19231

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb99cb9
self.partial_fit -> self.partial_fit_
jeremiedbb Jan 21, 2021
df48f35
Merge branch 'master' into fix-birch-first-call-check
jeremiedbb Jan 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 2 sklearn/cluster/_birch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ def fit(self, X, y=None):

def _fit(self, X):
has_root = getattr(self, 'root_', None)
first_call = self.fit_ or self.partial_fit and not has_root
first_call = self.fit_ or (self.partial_fit_ and not has_root)

X = self._validate_data(X, accept_sparse='csr', copy=self.copy,
reset=first_call)
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.