Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix misuse of self.partial_fit in Birch #19231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2021

Conversation

jeremiedbb
Copy link
Member

It's a bug but the code was already working because self.partial_fit is the method of the class and always evaluates to True, so this change has no impact on the behavior.

I added parenthesis to make it clearer at first sight, but it's not necessary.

@jeremiedbb jeremiedbb changed the title Fix misuse of self.partial_fit in Brich Fix misuse of self.partial_fit in Birch Jan 21, 2021
Base automatically changed from master to main January 22, 2021 10:54
@adrinjalali adrinjalali merged commit 3b3b7f5 into scikit-learn:main Jan 23, 2021
@glemaitre glemaitre added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label Feb 11, 2021
@glemaitre glemaitre added this to the 0.24.2 milestone Feb 11, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:cluster To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.