Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 407fd2d

Browse filesBrowse files
committed
remote URL valdation dependance on oauthlib
- oauthlib can't properly verify some of the URL fragments we have in our fixtures - switch to a more relaxed URL validation: run it through urllib.parse and hope to get the same URL out you put in - switches to using the standard library instead of an external dependency
1 parent 0437267 commit 407fd2d
Copy full SHA for 407fd2d

3 files changed

+9-14Lines changed: 9 additions & 14 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎caliper/base.py‎

Copy file name to clipboardExpand all lines: caliper/base.py
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
from aniso8601 import (parse_datetime as aniso_parse_datetime, parse_date as
3030
aniso_parse_date, parse_time as aniso_parse_time,
3131
parse_duration as aniso_parse_duration)
32-
from oauthlib import uri_validate as oauthlib_uri_validate
32+
from urllib.parse import urlparse as urllib_urlparse
3333

3434
from caliper.constants import CALIPER_CLASSES
3535

@@ -71,7 +71,7 @@ def is_valid_time(time):
7171
def is_valid_URI(uri):
7272
if not uri:
7373
return False
74-
elif isinstance(uri, str) and oauthlib_uri_validate.is_uri(uri):
74+
elif isinstance(uri, str) and (urllib_urlparse(uri).geturl() == uri):
7575
return True
7676
else:
7777
return False
Collapse file

‎setup.py‎

Copy file name to clipboardExpand all lines: setup.py
+4-6Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,11 @@
1717
os.system('python setup.py sdist upload')
1818
sys.exit()
1919

20-
_packages = ['caliper', 'caliper.extern', 'caliper.util', 'caliper_tests']
20+
_packages = ['caliper', 'caliper.extern', 'caliper.util', 'tests']
2121

22-
_requires = ['aniso8601 >= 1.1.0', 'future >= 0.14.3', 'oauthlib >= 0.7.2',
23-
'requests >= 2.7.0']
22+
_requires = ['aniso8601 >= 1.1.0', 'future >= 0.14.3', 'requests >= 2.7.0']
2423

25-
_fixtures = ['fixtures_local/*.json',
26-
'fixtures_common/src/test/resources/fixtures/*.json']
24+
_fixtures = ['fixtures_common/src/test/resources/fixtures/*.json']
2725

2826

2927
def _get_val_from_mod(k):
@@ -49,7 +47,7 @@ def _get_val_from_mod(k):
4947
maintainer_email='info@imsglobal.org',
5048
url='https://github.com/IMSGlobal/caliper-python',
5149
packages=_packages,
52-
package_data={'caliper_tests': _fixtures},
50+
package_data={'tests': _fixtures},
5351
install_requires=_requires,
5452
license=_license,
5553
zip_safe=False,
Collapse file

‎tox.ini‎

Copy file name to clipboard
+3-6Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
11
[tox]
2-
envlist = py27, py35
2+
envlist = py35, py27
33

44
[testenv]
5-
changedir = caliper_tests
6-
commands =
7-
discover
5+
changedir = tests
86
deps =
97
aniso8601
108
discover
119
future
12-
oauthlib
1310
requests
14-
11+
commands = discover

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.