Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2510595

Browse filesBrowse files
committed
use rfc3986 as license-friendly validation of URIs
1 parent 0f9c9c9 commit 2510595
Copy full SHA for 2510595

4 files changed

+9-3Lines changed: 9 additions & 3 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎README.rst‎

Copy file name to clipboardExpand all lines: README.rst
+3-1Lines changed: 3 additions & 1 deletion
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@ packages:
1919

2020
* requests -- (Apache 2 licensed)
2121

22-
* tox, discover -- (soft-dependency used only for tests, MIT licensed)
22+
* rfc3986 -- (Apache 2 licensed)
23+
24+
* tox, discover -- (soft-dependencies used only for tests, MIT licensed)
2325

2426
To work with the `imsglobal_caliper` bundle (maintain, use, run tests) you'll need
2527
to have these third-party packages in your local Python environment.
Collapse file

‎caliper/base.py‎

Copy file name to clipboardExpand all lines: caliper/base.py
+4-1Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import collections, copy, importlib, json, re, warnings
2828
from aniso8601 import (parse_datetime as aniso_parse_datetime, parse_date as aniso_parse_date,
2929
parse_time as aniso_parse_time, parse_duration as aniso_parse_duration)
30+
from rfc3986 import is_valid_uri as rfc3986_is_valid_uri
3031
from urllib.parse import urlparse as urllib_urlparse
3132

3233
from caliper.constants import CALIPER_CLASSES, CALIPER_TYPES
@@ -69,7 +70,9 @@ def is_valid_time(time):
6970
def is_valid_URI(uri):
7071
if not uri:
7172
return False
72-
elif isinstance(uri, str) and (urllib_urlparse(uri).geturl() == uri):
73+
elif (isinstance(uri, str)
74+
and (urllib_urlparse(uri).geturl() == uri)
75+
and rfc3986_is_valid_uri(uri)):
7376
return True
7477
else:
7578
return False
Collapse file

‎setup.py‎

Copy file name to clipboardExpand all lines: setup.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
_packages = ['caliper', 'caliper.util', 'caliper_tests']
2121

22-
_requires = ['aniso8601 >= 1.1.0', 'future >= 0.14.3', 'requests >= 2.7.0']
22+
_requires = ['aniso8601 >= 1.1.0', 'future >= 0.14.3', 'requests >= 2.7.0', 'rfc3986 == 0.4.1']
2323

2424
_fixtures = ['fixtures/src/test/resources/fixtures/*.json']
2525

Collapse file

‎tox.ini‎

Copy file name to clipboardExpand all lines: tox.ini
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,5 @@ deps =
88
discover
99
future
1010
requests
11+
rfc3986
1112
commands = discover

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.