Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[patchmanager.cpp] Reintroduce two dummy methods for documentation …#452

Merged
Olf0 merged 5 commits into
mastersailfishos-patches/patchmanager:masterfrom
silence-qdoc-warnings-v2sailfishos-patches/patchmanager:silence-qdoc-warnings-v2Copy head branch name to clipboard
May 8, 2024
Merged

[patchmanager.cpp] Reintroduce two dummy methods for documentation …#452
Olf0 merged 5 commits into
mastersailfishos-patches/patchmanager:masterfrom
silence-qdoc-warnings-v2sailfishos-patches/patchmanager:silence-qdoc-warnings-v2Copy head branch name to clipboard

Conversation

@Olf0

@Olf0 Olf0 commented Aug 15, 2023

Copy link
Copy Markdown
Contributor

… purposes only in order to silence qdoc warnings WRT undocumented classes, methods and functions.
Reference: The core aspect of the whole back and forth in PR #451: #451

…rposes only

Reference: The core aspect of the whole back and forth in PR #451: #451
@Olf0
Olf0 marked this pull request as draft August 15, 2023 23:08
@Olf0

Olf0 commented Aug 15, 2023

Copy link
Copy Markdown
Contributor Author

@nephros: Trying to resurrect this, adding all the info gathered meanwhile.
Please alter it to your liking, e.g., your original, unchanged documentation text lines (two for each method).

The dummy operations utilising patch and version respectively easterText still need to be implemented, see the corresponding [-Werror=unused-parameter] outputs.

@Olf0 Olf0 changed the title [patchmanager.cpp] Reintroduce two dummy methods for documentation purposes only [patchmanager.cpp] Reintroduce two dummy methods for documentation … Aug 15, 2023
@nephros
nephros marked this pull request as ready for review May 6, 2024 16:28
@Olf0

Olf0 commented May 8, 2024

Copy link
Copy Markdown
Contributor Author

Oh, I completely forgot about this and rereading the changes now (almost a year after writing them) does not bring memories back. As I assume this still makes sense (though I do not know that any longer), and both @b100dian and @nephros do not object, I will merge this.

@Olf0
Olf0 merged commit 3c19765 into master May 8, 2024
@Olf0
Olf0 deleted the silence-qdoc-warnings-v2 branch May 8, 2024 14:00
nephros pushed a commit to nephros/patchmanager that referenced this pull request May 28, 2024
nephros pushed a commit to nephros/patchmanager that referenced this pull request May 28, 2024
nephros pushed a commit to nephros/patchmanager that referenced this pull request May 28, 2024
nephros pushed a commit to nephros/patchmanager that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.