Skip to content

Navigation Menu

Sign in
Appearance settings
Sign up
Appearance settings

Commit 7ba5539

Browse filesBrowse the repository at this point in the historyBrowse files
committed
[qt] Don't call method on null WalletModel object
This doesn't crash currently because the method doesn't access any object members, but this behavior is fragile and incompatible with bitcoin#10102.
1 parent 987a6c0 commit 7ba5539
Copy full SHA for 7ba5539

1 file changed

+3-1Lines changed: 3 additions & 1 deletion

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/qt/sendcoinsdialog.cpp‎

Copy file name to clipboardExpand all lines: src/qt/sendcoinsdialog.cpp
+3-1Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ SendCoinsDialog::SendCoinsDialog(const PlatformStyle *_platformStyle, QWidget *p
114114
ui->groupCustomFee->button((int)std::max(0, std::min(1, settings.value("nCustomFeeRadio").toInt())))->setChecked(true);
115115
ui->customFee->setValue(settings.value("nTransactionFee").toLongLong());
116116
ui->checkBoxMinimumFee->setChecked(settings.value("fPayOnlyMinFee").toBool());
117-
ui->optInRBF->setCheckState(model->getDefaultWalletRbf() ? Qt::Checked : Qt::Unchecked);
118117
minimizeFeeSection(settings.value("fFeeSectionMinimized").toBool());
119118
}
120119

@@ -175,6 +174,9 @@ void SendCoinsDialog::setModel(WalletModel *_model)
175174
updateSmartFeeLabel();
176175
updateGlobalFeeVariables();
177176

177+
// set default rbf checkbox state
178+
ui->optInRBF->setCheckState(model->getDefaultWalletRbf() ? Qt::Checked : Qt::Unchecked);
179+
178180
// set the smartfee-sliders default value (wallets default conf.target or last stored value)
179181
QSettings settings;
180182
if (settings.value("nSmartFeeSliderPosition").toInt() == 0)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.