DRAFT - Angular 22 support#1922
Draft
CarinaGaspar wants to merge 9 commits into
rx-angular:mainrx-angular/rx-angular:mainfrom
CarinaGaspar:my-feature-cleanCarinaGaspar/rx-angular-22-support:my-feature-cleanCopy head branch name to clipboard
Draft
DRAFT - Angular 22 support#1922CarinaGaspar wants to merge 9 commits intorx-angular:mainrx-angular/rx-angular:mainfrom CarinaGaspar:my-feature-cleanCarinaGaspar/rx-angular-22-support:my-feature-cleanCopy head branch name to clipboard
CarinaGaspar wants to merge 9 commits into
rx-angular:mainrx-angular/rx-angular:mainfrom
CarinaGaspar:my-feature-cleanCarinaGaspar/rx-angular-22-support:my-feature-cleanCopy head branch name to clipboard
Conversation
Angular 22's application builder loads the esbuild plugin through Node's native TypeScript type-stripping loader, which does strict ESM resolution: it requires explicit file extensions and does not resolve directory indexes. Add explicit .ts extensions across the plugin's reachable module graph, enable rewriteRelativeImportExtensions so the publish build emits .js, and allowImportingTsExtensions in the spec tsconfig for ts-jest.
Angular 22 upgrades ESLint to v9, whose flat-config RuleTester no longer accepts the top-level parser key. Use languageOptions.parser with an imported @typescript-eslint/parser instead of require.resolve.
Prettier reflowed the guard condition, which moved a // @ts-ignore off the line it suppressed and resurfaced TS2339 on memoize.numArgs. Give memoize an explicit type so the extra properties are known without suppression.
Regenerate the lockfile so it matches the bumped package.json (restores shiki and other main-only dependencies dropped during the merge).
Result of running the lint-staged formatters (prettier --write, eslint --fix) repo-wide; no functional changes.
Replace deep relative imports into library source
(../../../libs/template/{push,unpatch,let}/src/lib/...) with the public
@rx-angular/template/{push,unpatch,let} entry points, resolving
@nx/enforce-module-boundaries violations surfaced by the ESLint 9 flat
config.
Result of running the lint-staged formatters repo-wide; no functional changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still depending on #1919